Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(win/nvenc): add split frame encoding option #3061

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(win/nvenc): add split frame encoding option #3061

wants to merge 2 commits into from

Conversation

ns6089
Copy link
Contributor

@ns6089 ns6089 commented Aug 22, 2024 •
edited
Loading

Description

Support split frame encoding

Screenshot

2024-08-22 14_53_32-Window

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ns6089 ns6089 marked this pull request as ready for review August 22, 2024 11:54
@ns6089 ns6089 changed the title feat(win/nvenc): add split-frame encoding option feat(win/nvenc): add split frame encoding option Aug 22, 2024
@ns6089 ns6089 force-pushed the nvenc_split_frame branch from eeb632d to 995c193 Compare August 23, 2024 04:36
@ns6089 ns6089 force-pushed the nvenc_split_frame branch from 995c193 to 2ddf1b8 Compare August 23, 2024 05:53
@ns6089
Copy link
Contributor Author

ns6089 commented Aug 25, 2024

The code in this pull request is Not a Contribution under LizardByte Individual Contributor License Agreement.
The code in this pull request is shared under GNU GENERAL PUBLIC LICENSE Version 3.

@ReenigneArcher ReenigneArcher marked this pull request as draft August 25, 2024 04:22
@moi952
Copy link

moi952 commented Aug 26, 2024

Hi @ns6089 I see your tickets are closed and merged, is there a reason?

Are you not going to contribute to sunshine anymore?

@ReenigneArcher

This comment was marked as off-topic.

Sign in to view
@moi952

This comment was marked as off-topic.

Sign in to view
@ns6089

This comment was marked as off-topic.

Sign in to view
@cgutman

This comment was marked as off-topic.

Sign in to view
@cgutman cgutman reopened this Aug 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
127 New issues
124 New Code Smells (required ≤ 0)
3 New Bugs (required ≤ 0)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@LizardByte-bot
Copy link
Member

It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ns6089 @moi952 @ReenigneArcher @cgutman @LizardByte-bot